Ticket #118 (closed patch: fixed)

Opened 2 years ago

Last modified 2 weeks ago

Deleate, count

Reported by: tcopeland Owned by: hamish
Priority: minor Milestone:
Component: CMS - General Version:
Severity: medium effort / impact Keywords:
Cc: hn.campbell@… Hours:

Description (last modified by sminnee) (diff)

There is a problem with the "count" for pages which are being deleated. To replicate

  • Deleate mode
  • Select a page with a parent, press deleate
  • Cancel the message - "do you want to deleate the 1 marked pages
  • Now also select it's parent page, select deleate
  • message now reads "do you want to deleate the 3 marked pages", even though 2 pages are marked

Attachments

CMSMain_left.js.diff (1.2 kB) - added by hamish 5 weeks ago.
Path for cms/javascript/CMSMain_left.js

Change History

Changed 2 years ago by jshipman

Hayden Smith 24 Aug 2006, 2:21pm Changed status to Fixed.

Fixed. deletepage.selectedNode is set to {} on success.

Sam Minnee 1 Aug 2006, 6:14pm Due on 7 Aug. Sam Minnee 1 Aug 2006, 5:38pm

It doesn't reset its wee internal list of pages.

Hayden Smith 26 Jul 2006, 4:06pm Due on 1 Sep.

Changed 10 months ago by sharvey

  • status changed from closed to reopened
  • harvest_task set to (Unknown)
  • invoice_sent set to 0
  • version 2.0 deleted
  • resolution worksforme deleted

This isn't fixed. I'm still getting the same problem on 2.2.1

Hit the "Batch actions" button on a page with 1 child page, should say "Do you wish to delete the 2 marked pages?", now, if you click the child page which is greyed out, it says "Do you want to delete 3 pages?" - clearly this is not 3, but 2.

Changed 10 months ago by sminnee

  • priority changed from medium to minor
  • description modified (diff)

Changed 5 weeks ago by hamish

  • cc hn.campbell@… added
  • owner changed from hsmith to hamish
  • status changed from reopened to new
  • type changed from defect to patch

Patch attached. It wasn't checked whether previously marked tree nodes where being added. The change puts them into an array and uses the prototype indexOf extension to check for it's existence first.

Changed 5 weeks ago by hamish

Path for cms/javascript/CMSMain_left.js

Changed 5 weeks ago by hamish

  • status changed from new to assigned

Changed 5 weeks ago by hamish

  • owner changed from hamish to sminnee
  • status changed from assigned to new

Changed 5 weeks ago by hamish

  • owner changed from sminnee to hamish
  • status changed from new to assigned

Changed 2 weeks ago by aoneil

  • status changed from assigned to closed
  • resolution set to fixed

Committed in r66162, thanks hamish!

Note: See TracTickets for help on using tickets.