Deleate, count

[tcopeland]

There is a problem with the "count" for pages which are being deleated. To replicate

• Deleate mode
• Select a page with a parent, press deleate
• Cancel the message - "do you want to deleate the 1 marked pages
• Now also select it's parent page, select deleate
• message now reads "do you want to deleate the 3 marked pages", even though 2 pages are marked

[jshipman]

Hayden Smith 24 Aug 2006, 2:21pm Changed status to Fixed.

Fixed. deletepage.selectedNode is set to {} on success.

Sam Minnee 1 Aug 2006, 6:14pm Due on 7 Aug. Sam Minnee 1 Aug 2006, 5:38pm

It doesn't reset its wee internal list of pages.

Hayden Smith 26 Jul 2006, 4:06pm Due on 1 Sep.

[sharvey]

This isn't fixed. I'm still getting the same problem on 2.2.1

Hit the "Batch actions" button on a page with 1 child page, should say "Do you wish to delete the 2 marked pages?", now, if you click the child page which is greyed out, it says "Do you want to delete 3 pages?" - clearly this is not 3, but 2.

[hamish]

Patch attached. It wasn't checked whether previously marked tree nodes where being added. The change puts them into an array and uses the prototype indexOf extension to check for it's existence first.

[hamish]

Path for cms/javascript/CMSMain_left.js

[aoneil]

Committed in r66162, thanks hamish!