Ticket #1939 (closed defect: fixed)

Opened 9 months ago

Last modified 1 month ago

forum posts RSS fail

Reported by: smagnusson Assigned to: mpeel
Type: defect Priority: critical
Milestone: Forum 0.2 Component: Modules - forum
Version: Severity: medium effort / impact
Keywords: Cc:
Due date: Harvest Task: (Unknown)
Invoice sent to client: 0 Hours:

Attachments

PostWithZeroTopicID.sql (1.7 kB) - added by ischommer 5 months ago.

Change History

Changed 5 months ago by ischommer

traced back to some erroreous Post database rows on live (TopicID=0). they're all created in the span of 10 minutes, 5 rows in total (all other columns are null as well). i've attached a dump.

not sure what triggered this, but Post.php->RSSContent doesn't do any checking for the existence of certain objects, e.g. $myPost->Topic()->Title instead of if($myPost->Topic() ) $myPost->Topic()->Title

Changed 5 months ago by ischommer

Changed 5 months ago by smagnusson

That's lovely and all but I still cannot subscribe to feed://silverstripe.com/silverstripe-forum/rss in Apple Mail, so can we remove these posts or whatever? :)

Changed 5 months ago by ischommer

  • priority changed from medium to critical

hey sig, the posts were removed as of the date when my comment was posted, but apparently the feed broke again afterwards. i've removed another wrong post on the live site - so haven't really had time to investigate the root problem, just quick fixes.

DELETE FROM `Post` WHERE `TopicID` =0

matt, any ideas? this is an important issue, as it breaks one of the main points of contact between silverstripe and its community.

Changed 5 months ago by ischommer

matt, can you please spend your "opensource hour" next week on researching this issue?

Changed 5 months ago by aoneil

I've added TopicID > 0 to the WHERE clause, which solves this problem, but we still need to find the underlying cause of why these posts are being created.

Changed 5 months ago by ischommer

cheers andy :)

also, the rss entries have lost their links somehow: feed://www.silverstripe.com/silverstripe-forum/rss :/

Changed 5 months ago by aoneil

Links fixed :)

Changed 1 month ago by sharvey

  • milestone set to Forum 0.2

Changed 1 month ago by wrossiter

  • status changed from new to closed
  • resolution set to fixed

commited andys fix to trunk.

Note: See TracTickets for help on using tickets.