Ticket #1945 (new patch)

Opened 13 months ago

Last modified 3 months ago

Allowing changing of default home page

Reported by: Jerr Owned by: sminnee
Priority: medium Milestone: 2.3.1
Component: Sapphire Framework Version: 2.2.0
Severity: medium effort / impact Keywords: notformerge
Cc: Hours:

Description

$URL: svn://svn.silverstripe.com/silverstripe/open/modules/cms/tags/2.2.0/silverstripe_version $ I created this patch so that you can put in _config.php: RootURLController::set_default_root("some-other-page");

This allows you to set something other than "home" as the site's default. The old way had "home" hardcoded in, but here you can set a different default. Note that it defaults to "home" if set_default_root is never called.

Attachments

patch.diff (1.1 kB) - added by Jerr 13 months ago.
Patch file for /sapphire/core/control/RootURLController

Change History

Changed 13 months ago by Jerr

Patch file for /sapphire/core/control/RootURLController

  Changed 13 months ago by Jerr

  • version set to 2.2.0

follow-up: ↓ 3   Changed 13 months ago by sminnee

  • milestone set to 2.2.2 feature-lock

One of the issue here is that the text "home" is never actually used in a URL.

There's currently a field for specifying that a page is the homepage for particular domains, and the 'home' page is used in the default case. Perhaps we should add a boolean field on behaviour for saying that the page is the homepage?

in reply to: ↑ 2   Changed 13 months ago by Jerr

Replying to sminnee:

One of the issue here is that the text "home" is never actually used in a URL. There's currently a field for specifying that a page is the homepage for particular domains, and the 'home' page is used in the default case. Perhaps we should add a boolean field on behaviour for saying that the page is the homepage?

We discussed this in the IRC channel, but this patch was a very quick fix to it. I think the boolean field would be the best fix for it, especially since there already is a field there for specific domains.

  Changed 13 months ago by sminnee

I think that it's probably best to make the boolean-field based fix for the official version, but this patch is available to anyone who wants to download an merge it themselves before that.

  Changed 12 months ago by sminnee

  • keywords notformerge added

I'm adding the "notformerge" keyword to this, so that this doesn't appear on the "active patches" report.

  Changed 11 months ago by sminnee

  • milestone changed from 2.2.2 feature-lock to 2.2.3 feature-lock

  Changed 4 months ago by ischommer

  • milestone changed from 2.2.3* to 2.3.0

  Changed 3 months ago by sminnee

  • milestone changed from 2.3.0 to 2.3.1*
Note: See TracTickets for help on using tickets.