Statistics section dies on memory usage.

[dio5]

I'm on dreamhost with 90M memory limit, still I can't access my statistics section in the cms, getting fatal 'out of memory' errors.

We've tried on several other sites as well on different hostings, with the same result.

I tried with jam13 who put one of his sites at 128M. Then the errors were gone, but he just got a blank page.

The stats section is eating to many memory, or doing something very inefficiently.

I'm filing it at 'critical' because the whole section is broken, of course it won't hurt the main section of the cms.

[dio5]

I wonder how much the next line weighs on the memory usage:

line 39 of Statistics.php:

$record = DataObject::get($class, "", $class.".Created DESC");
$total = $record->TotalItems();
$props = $record->toArray();
$props = $props[0]->toMap();
...

It looks like it's getting every row from the PageView? table by using DataObject::get() without limit.

The PageView? table inserts every view as a new row, so that is a table that quickly grows into thousands of rows, which thus creates a massive DataObject? and then a HUUUGE array.

I believe this needs some rethinking, because there will be no site that can handle this :)

[sminnee]

This definitely needs some re-thinking, and will get that re-thinking in 2.2.3. We'll be revamping the reporting system for that release, too.