Ticket #2163 (new defect)

Opened 12 months ago

Last modified 2 months ago

Translation sitetree messed up

Reported by: mpeel Owned by: wakeless
Priority: medium Milestone: 2.4.0
Component: Sapphire Framework Version: 2.2.0
Severity: medium effort / impact Keywords: notformerge
Cc: Hours:

Description

The Translatable stuff is a bit screwy - for example in the site tree you can't view all children of a page, just the root children.

Here's a patch that goes too far in what it's trying to do :P

Basically, Ingo and I tried to make the translation system use other means than session to communicate that we were creating a new translation for a page, but found this to be too complicated.

This patch should be applied to 2.2.1 and will BREAK the CMS horribly.

My thoughts: Let's revert 70% of this patch, so that only these things stay:

  • Changes made to CMSMain::switchlanguage() (because we want to show the whole site tree)
  • Adding the marking filters to Hierarchy and Translatable, and editing the SiteTree::CMSTreeClasses() method to check if the node is translated or not.
  • Fix Translatable::isTranslatedInto() to return something that actually makes sense.

Attachments

translation-buggery-cms.patch (6.8 kB) - added by mpeel 12 months ago.
translation-buggery-sapphire.patch (5.1 kB) - added by mpeel 12 months ago.

Change History

Changed 12 months ago by mpeel

Changed 12 months ago by mpeel

Changed 12 months ago by mpeel

mpeel also has a copy of all the site files on his machine at /home/mpeel/Programming/dnc-buggy-translation so ask him if there is something missing or you have questions :>

Changed 11 months ago by sminnee

  • keywords notformerge added

I'm marking this as "notformerge" until someone cleans up the patch :-P

Changed 3 months ago by sminnee

  • owner changed from mpeel to ischommer

Changed 3 months ago by ischommer

  • owner changed from ischommer to wakeless

reassigning to wakeless - can you please have a look at this to see if it influences or improves your current work? if its incompatible with what you're doing, and you've addressed this problem, mark it as invalid. if its just incompatible, but should be solved, please detail what needs to be done :)

Changed 2 months ago by sminnee

  • milestone changed from 2.3.0-rc1 to 2.4.0
Note: See TracTickets for help on using tickets.