"Odd" record detection in control breaks not working correctly

[newjamie]

In a control, the <% if Odd %> statement only returns true on the first odd row, not continually throughout the firing of the control block.

For example

<% control Children %>

<% if Odd %>

Odd row %>

<% end_if %> ...

<% end_control %>

only fires one time, despite their being 8 children and the control block iterating the correct number of times.

I don't know if this is a problem just with the built-in Children control or all controls.

A temporary fix is to use:

<% control Children %>

<% if Even %>

<!-- do nothing -->

<% else %>

Odd row

<% end_if %> ...

<% end_control %>

[newjamie]

Read the mistyped line

Odd row %>

as

Odd row

in the above, for the correct syntax.

[sminnee]

Tagging as "easy". This should be a simple fix of ViewableData::Odd(). Compare it to Even().

[dashiel]

Uploaded a new version of ViewableData?.php that changed line 647 from

return !$this->iteratorPos % 2;

to

return !$this->Even();