Ticket #2322 (closed patch: fixed)
[patch] Editable Checkbox Groups in user defined forms should display the field's name, not a pointless number
| Reported by: | DanielVF | Assigned to: | aoneil |
|---|---|---|---|
| Type: | patch | Priority: | medium |
| Milestone: | Component: | (Unknown) | |
| Version: | 2.2.2-rc1 | Severity: | medium effort / impact |
| Keywords: | Cc: | ||
| Due date: | Harvest Task: | (Unknown) | |
| Invoice sent to client: | 0 | Hours: |
Description
Checkbox groups in user defined forms are currently emailing you numbers for the results. Your emails look like:
Areas of volunteer interest:1,2,3,4,5
They should look like:
Areas of volunteer interest: Distribute food, Donation pick-ups, Office support maintenance, Retail/thrift store, Recreation special events, Data entry for THCO
This patch fixes this.
EditableCheckboxGroupField.php
@@ -137,10 +138,11 @@
$selectedOptions = DataObject::get( 'EditableCheckboxOption', "ParentID={$this->ID} AND ID IN (".implode(',',$entries).")" );
foreach( $selectedOptions as $selected ) {
if( !$result )
- $result = $selected->ID;
+ $result = $selected->Title;
else
- $result .= "," . $selected->ID;
+ $result .= ", " . $selected->Title;
}
+
return $result;
}
Attachments
Change History
Note: See
TracTickets for help on using
tickets.
