Database name with dash/hyphen can't be used

[bmatzner]

The install dialog automatically removes dashes from the database name. There should not be unnecessary restrictions to database names, as some ISP have their naming standards that can't be controlled. In my case, I had to change the db name to something the installer accepts, then change it afterwards and manually alter the config file. Now it works, but this could be a blocker if you can't rename databases. Also valid in 2.2.1

[ischommer]

Good idea; we'll have a look at this in the next version. Right now we're focusing on nailing bugs that were working in previous releases -- this doesn't fall into that category.

[Blynx]

There are 2 simple fixes:
1) Turn off Javascript, or
2) Edit the "config-form.html" in the root directory, and replace line 110

<span class="middleColumn"><input id="mysql_database" class="text" type="text" name="mysql[database]" value="<?php echo $databaseConfig['database']; ?>" onchange="this.value = this.value.replace(/[^A-Za-z0-9_]+/g,'');" /></span>

with

<span class="middleColumn"><input id="mysql_database" class="text" type="text" name="mysql[database]" value="<?php echo $databaseConfig['database']; ?>" onchange="this.value = this.value.replace(/[^A-Za-z0-9_-]+/g,'');" /></span>

The same way you can add any character into the regular expression and use whatever database name you like.

Cheers, Blynx

btw: Is there any way to submit such comments as a patch, instead if just a simple comment?

[lenix]

it should be easier to fix than to change to milestone..

http://dev.mysql.com/doc/refman/5.0/en/identifiers.html explains valid database-names.

[smagnusson]

I have confirmed that the bug is limited to not escaping the "CREATE DATABASE command"

With 2.3.0rc2 if you manually create "SS-mysite" and then use that in the installer, where it will say 'database exists', and then click 'install', all works perfectly. The installer has no errors, and the website/CMS loads correctly.

So, the current workaround is to edit sapphire/dev/install/config-form.html as above, to allow hyphens in the name, and to create the database manually before clicking 'install'.

[sminnee]

Fixed in r69715.