cheque message should be taken out of checkoutpage in e-commerce module

[nicolaas]

Right now the cheque message (e.g. when you are paying by cheque) is part of the checkoutpage. This should be made part of the cheque payment method. Depending on the payment types selected, the CMS should be prompted for these message in perhaps a special payment page.

Right now, I would like to add a paypal message, but I am not sure how to do this as there is a precedent for the cheque message, but it makes a lot more sense to have it in the paypalPayment Class.

[rlouis]

This is another problem that needs to be fixed.

How to manage the payments and modifiers text and/or explications ?

If in the CMS, the fields like ChequeMessage? have to be added to CheckoutPage? by another way than putting them manually by using a 'kind of' Decorator system.

I mean by that add to Payment class a function extraCheckoutPageDBFields() but I am still not sure that this system is the best.

[nicolaas]

Hi

It definitely would make most sense to add the field (or group of fields) to the payment class. Question is where you can edit them in the CMS.

[jshipman]

This is part of ChequePayment? now. This was fixed up with the new model.

See line 15: http://open.silverstripe.com/browser/modules/ecommerce/trunk/code/payments/ChequePayment.php

[jshipman]

Actually, on closer inspection, I don't think we're quite at this stage.

Payments have a message DB field, which is populated with their default message when the processPayment method is called....at least that is the case for cheques.

The PayPal? payment does not populate the message DB field, as far as I can tell.