missing images for the html toolbar in the CMS

[nicolaas]

In the HTML toolbar four images are missing:

insert row before insert row after insert column before insert column after

[sharvey]

Hi Nicolaas,

Is this rc2 or rc3? Also, what browser? On branches/2.2.0 I can see these images in the toolbar using Firefox 2.0.0.14/Mac

[sharvey]

Sorry, branches/2.2.2, I mean

[nicolaas]

rc3 with firefox.... I have noticed this a few times actually. Not sure what the story is. I will investigate, but it may take me a while...

[sminnee]

I think that this may be to do with the line-ending settings on the (binary) files in svn.

Sean - we need to figure out how to mark them as binary in svn. I think that it's one of the svn propset options - perhaps you can look at this info in eclipse?

[sharvey]

I'm not sure that's the cause. All the images I've found have "application/octet-stream", and if it has a mime-type of anything other than "text/*", then it's binary. All the images in that directory have the same "application/octet-stream" mime-type.

According to this page, SVN already attempts to ensure the have a binary mime-type when you "svn add" or "svn import" binary files. I've checked all the images, and they have the correct mime-type:

http://svnbook.red-bean.com/en/1.1/apas08.html

"Subversion examines the svn:mime-type property. If the file has no svn:mime-type property, or has a mime-type that is textual (e.g. text/*), Subversion assumes it is text. Otherwise, Subversion assumes the file is binary. Subversion also helps users by running a binary-detection algorithm in the svn import and svn add commands. These commands will make a good guess and then (possibly) set a binary svn:mime-type property on the file being added. (If Subversion guesses wrong, the user can always remove or hand-edit the property.)"

Other things I'll check is running "svn export" on a 2.2.2-rc3 release, running "svn checkout" on a 2.2.2-rc3 release, and finally installing via the rc3 file download to see if there's any differences.

[sharvey]

Nicolaas, just out of interest, did you copy the rc3 sapphire, jsparty, and cms files to upgrade an existing copy of SilverStripe?, or install rc3 from scratch?

[sharvey]

Still can't reproduce this ....

[nicolaas]

I will try to find out how it is not working.

Cheers

Nicolaas