Ticket #2460 (new enhancement)

Opened 2 months ago

Last modified 1 month ago

geocoder field

Reported by: nicolaas Assigned to: ischommer
Type: enhancement Priority: medium
Milestone: Component: Modules - Google Maps
Version: 2.2.2-rc2 Severity: medium effort / impact
Keywords: Cc:
Due date: Harvest Task: (Unknown)
Invoice sent to client: 0 Hours:

Description

Here is a rework of the geocoder field with an example.

Attachments

GeocoderField.zip (4.3 kB) - added by nicolaas 2 months ago.
it contains the field as well as a pagetype and a dataobject to save into

Change History

Changed 2 months ago by nicolaas

it contains the field as well as a pagetype and a dataobject to save into

Changed 2 months ago by nicolaas

note, I have used jQuery for this application as it looks like SS will use this in the future!

Changed 2 months ago by ischommer

  • owner changed from opicazo to ischommer
  • priority changed from critical to medium

hi nicolaas, thanks for your work! some notes:

  • usually we're happier with a patch in unified diff format (plus a zip for new files) - makes review a lot easier
  • can you please shorten and rework your examples in the phpdoc header (in <code><?php ?></code) wrap) of GeocoderField?.php? we don't want them to show up as executable files included by /db/build - and we're moving towards integrating more documentation within the phpdoc (as opposed to doc.silverstripe.com)
  • the javascript shouldn't be inline - can you please add a GeocoderField?.js
  • the javascript should be a self-contained jquery plugin (currently its inline javascript executed on a toplevel namespace), see http://docs.jquery.com/Plugins/Authoring - thanks for adapting to our jQuery plans so early :)
  • public static $AccuracyZoomAdder? = "8"; - wrong coding conventions and a bit unusual naming, how about $accuracy_zoom_base

i currently can't view the diff manually, so might hve more feedback later on

Changed 2 months ago by nicolaas

  • usually we're happier with a patch in unified diff format (plus a zip for new files) - makes review a lot easier

- SORRY I HAD NO IDEA HOW TO DO THAT AND NOWHERE ON THE SITE IS A REFERENCE TO THIS AFAIK - HAPPY TO DO SO. ALL OTHER CHANGES MAKE SENSE.

Changed 1 month ago by ischommer

nicolaas, any updates on this?

Note: See TracTickets for help on using tickets.