geocoder field

[nicolaas]

Here is a rework of the geocoder field with an example.

[nicolaas]

it contains the field as well as a pagetype and a dataobject to save into

[nicolaas]

note, I have used jQuery for this application as it looks like SS will use this in the future!

[ischommer]

hi nicolaas, thanks for your work! some notes:

• usually we're happier with a patch in unified diff format (plus a zip for new files) - makes review a lot easier
• can you please shorten and rework your examples in the phpdoc header (in <code><?php ?></code) wrap) of GeocoderField?.php? we don't want them to show up as executable files included by /db/build - and we're moving towards integrating more documentation within the phpdoc (as opposed to doc.silverstripe.com)
• the javascript shouldn't be inline - can you please add a GeocoderField?.js
• the javascript should be a self-contained jquery plugin (currently its inline javascript executed on a toplevel namespace), see http://docs.jquery.com/Plugins/Authoring - thanks for adapting to our jQuery plans so early :)
• public static $AccuracyZoomAdder? = "8"; - wrong coding conventions and a bit unusual naming, how about $accuracy_zoom_base

i currently can't view the diff manually, so might hve more feedback later on

[nicolaas]

• usually we're happier with a patch in unified diff format (plus a zip for new files) - makes review a lot easier

- SORRY I HAD NO IDEA HOW TO DO THAT AND NOWHERE ON THE SITE IS A REFERENCE TO THIS AFAIK - HAPPY TO DO SO. ALL OTHER CHANGES MAKE SENSE.

[ischommer]

http://open.silverstripe.com/#Submissionguidelines

THANKS ;)

[ischommer]

nicolaas, any updates on this?