Ticket #2524 (closed defect: fixed)

Opened 8 months ago

Last modified 3 months ago

Files in AssetAdmin not uploading

Reported by: Delphinus Owned by: sharvey
Priority: critical Milestone: 2.3.0-rc1*
Component: CMS - Files and Images section Version: 2.2.2-rc2
Severity: medium effort / impact Keywords:
Cc: Hours:

Description

Follow on from #2343
File uploads are still failing on most browsers.

Running 2.2.2rc5.

The following browsers work for me:
Firefox 2.0.0.11 on Kubuntu7.10
Ie7 on Window XP SP2

The following browsers fail:
Firefox 2.0.0.14 on Windows XP
Firefox 3rc1 on Windows XP
ie6 on Windows XP
ie7 on Windows Vista

When clicking "upload the files listed below" the grey bar fills up then the page hangs. Firefox sits on "transferring data from..." and IE shows a Syntax Error. Char 9, Line 182.
If you click on the uploads directory again it pops up with "You've been logged out of the server, so we're going to send you back to the log-in screen" and you get sent back to login screen.

Change History

Changed 8 months ago by ischommer

  • owner changed from ischommer to aoneil

cheers for the detailed report!

Changed 8 months ago by Delphinus

I got the following error from a friend running Firefox 2.0.0.14 on Vista.

XML tag name mismatch (expected link)
http://domain.com/cms/javascript/CMSMain_upload.js              Line: 193
</head>
  ^

Changed 8 months ago by manafta

The problem seems to occur with the latest Flash Player (9.0.124). Downgrading to an older version solved the problem for me. This implies that it cannot be fixed inside silverstripe.

Changed 8 months ago by Delphinus

That would be why its working for me on my linux machine. Running Flash 9.0 r48

Changed 8 months ago by sminnee

In the interests of reliability, we have disabled flash uploading on the Files & Images section.

We will make getting a reliable flash uploader a priority for 2.2.3. It will most likely involve something on the SWFUpload side of things being fixed.

We have left flash uploading when quick-uploading from the site content area (and fixed it), because it's not feasible to have a flashless uploader there.

r54959.

Changed 8 months ago by ischommer

  • milestone changed from 2.2.2-rc5* to 2.2.3 feature-lock

Changed 7 months ago by sminnee

It looks as if the problem is due to the flash HTTP request not including browser cookies. Probably some XSS-prevention change designed to annoy hardworking CMS developers. :-P

A potential solution will be to include a PHPSESSID variable in the querystring of the file-upload submission. Hopefully, PHP will be able to make use of this without special handling, but that will need some experimentation.

Thanks for pointing this out, Delphinus. :-)

Changed 4 months ago by ischommer

  • owner changed from aoneil to sminnee
  • summary changed from Files still not uploading to Files in AssetAdmin not uploading
  • milestone changed from 2.2.3 to 2.3.0

Not sure if this is still solveable in 2.3 - Sam?

Changed 3 months ago by sharvey

I don't see why we need to re-implement the flash uploader if we've proved it to be unreliable. The current system appears to work fine for the assets area. So it's missing an upload indicator, but I think we can live without that.

Only the content image insertion should contain the flash upload, as Sam said because it's not feasible to go without it there.

Changed 3 months ago by sminnee

  • owner changed from sminnee to sharvey

Good call, Sean; we have bigger fish to fry right now.

Sean - can you ensure that the uploading with the CMS works? Is this a separate ticket?

Changed 3 months ago by sharvey

I'll make sure that inline uploading in the "Site Content" area works. If it does (and I'll check in a few different browsers), then we can close this ticket for now.

Changed 3 months ago by sharvey

  • status changed from new to closed
  • resolution set to fixed

Well, unfortunately the inline uploader doesn't work. I'll create a new, separate ticket for that. However, this one should be closed.

Note: See TracTickets for help on using tickets.