Change changeset result of Ticket #1931

[3dkiwi]

I am working a module that will use a logo in the background and discovered the issue that Ticket #1931 resolved in Line 851 of LeftAndMain.php.

However the fix provided by the Ticket changeset 46741 restricts further styles being added via the $application_logo_style variable.

Original:

return "background-image: url(" . self::$application_logo . ") no-repeat; " . self::$application_logo_style;

Ticket #1931 fix:

return "background: url(" . self::$application_logo . ") no-repeat; " . self::$application_logo_style;

My Suggestion:

return "background-image: url(" . self::$application_logo . "); background-repeat: no-repeat; " . self::$application_logo_style;

This way additional styles such as background-fixed, background-position etc. can be added via the application_logo_style variable as needed.

Jim

[sminnee]

I don't see why this change is necessary; it make more work for people wanting to simply replace the logo.