Ticket #2624 (new defect)

Opened 3 months ago

Last modified 3 months ago

Bad XHTML in en_US language file

Reported by: tiwoc Assigned to: ischommer
Type: defect Priority: medium
Milestone: Component: i18n
Version: 2.2.2 Severity: medium effort / impact
Keywords: Cc:
Due date: Hours:

Description

In /sapphire/lang/en_US.php, there is bad XHTML in the first language string:

$lang['en_US']['ContentController']['DRAFT_SITE_ACCESS_RESTRICTION'] = 'You must log in with your CMS password in order to view the draft or archived content.  <a href=\"%s\">Click here to go back to the published site.</a>';

Since the text is enclosed in single quotes, \" in the "a" tag is wrong. This leads to ugly "XML processing failed" messages with Firefox. The tag should look like that:

<a href="%s">

In the language files other than en_US, this was already done right.

Attachments

silverstripe-2.2.2-lang.diff (1.1 kB) - added by tiwoc 2 months ago.
bugfix

Change History

Changed 3 months ago by tiwoc

To reproduce this bug, log into the CMS, select some page and click on "Draft Site" in the footer. On the draft site (not in the CMS), use the logout link. Now you'll get an XML error instead of the site you wanted to see.

Changed 2 months ago by tiwoc

bugfix

Note: See TracTickets for help on using tickets.