Ticket #2633 (closed patch: fixed)

Opened 6 months ago

Last modified 6 months ago

explicit instance member class

Reported by: quocbao Owned by: sminnee
Priority: medium Milestone:
Component: Sapphire Framework Version: 2.2.2
Severity: medium effort / impact Keywords:
Cc: Hours:

Description

I found this line in Member.php

$blankMember = new Member();

I think we should use

$blankMember = Object::create('Member');

This will remove dependency from the class itself, sound funny but it will help us later if we replace the whole Member record with other record.

Change History

Changed 6 months ago by sminnee

  • status changed from new to closed
  • resolution set to fixed

Good call; fixed in r57782.

Note: See TracTickets for help on using tickets.