Ticket #2637 (closed defect: fixed)

Opened 6 months ago

Last modified 3 months ago

sapphire/javascript/ComplexTableField_popup.js had faulty methode(s)

Reported by: rino@… Owned by: ischommer
Priority: critical Milestone: 2.3.0-rc1*
Component: CMS - Security section Version: 2.2.2
Severity: medium effort / impact Keywords: ComplexTableField_popup.js, saving user profile, javascript errors
Cc: Hours:

Description

in the release version 2.2.2 i found the following error:

the methode is missing the declaration of the variable "theForm" and should correctly read:


	ajaxErrorHandler: function(response) {
		var theForm =document.getElementsByTagName("form")[0];
		
		var submitButton = document.getElementsBySelector("input.action",theForm)[0];
		if(typeof submitButton != 'undefined') {
			submitButton.disabled = false;
			Element.removeClassName(submitButton,'loading');
		}
		
		// TODO does not work due to sandbox-iframe restrictions?
		if(typeof(parent.parent.ajaxErrorHandler) == 'function') {
			parent.parent.ajaxErrorHandler();
		} else {
			alert(this.errorMessage);
		}
	},

and in the current SVN version i found another error in the same script:

there is a comma missing at the very end after the declaration of the newly added methode "loadNewPage":


	loadNewPage : function(content) {
		this.innerHTML = content;
	}, // <-- Comma is missing!!!

Change History

Changed 3 months ago by sminnee

  • milestone changed from 2.2.3* to 2.3.0

Hopefully this is a quick-fix, Ingo?

Changed 3 months ago by ischommer

  • status changed from new to closed
  • resolution set to fixed

thats "fixed", because all javascript has been removed from the popup saving ;)

Note: See TracTickets for help on using tickets.